Comments on: new osc feature to review requests https://lizards.opensuse.org/2010/02/11/new-osc-feature-to-review-requests/ Blogs and Ramblings of the openSUSE Members Fri, 06 Mar 2020 17:50:09 +0000 hourly 1 https://wordpress.org/?v=4.7.5 By: Marcus Hüwe https://lizards.opensuse.org/2010/02/11/new-osc-feature-to-review-requests/#comment-1478 Thu, 11 Feb 2010 13:50:44 +0000 http://lizards.opensuse.org/?p=3210#comment-1478 Hmm it’s just a “misleading” help text. You can also set a request into a “review” state. This means that someone/some group is reviewing the request and others cannot accept/decline etc. this request while it’s in the review state (e.g. you have to run “osc review accept/decline “). But this review stuff isn’t completely implemented in osc yet (I don’t know why). It still misses a command to set the request’s state to “review” (you can do this manually via curl “https://api.opensuse.org/request/32197?cmd=addreview&by_user=Marcus_H” -d “some comment”).

]]>
By: Ludwig Nussel https://lizards.opensuse.org/2010/02/11/new-osc-feature-to-review-requests/#comment-1477 Thu, 11 Feb 2010 13:15:36 +0000 http://lizards.opensuse.org/?p=3210#comment-1477 no, ‘review’ is an alias for ‘request’. a misfeature imo

]]>
By: }-Tux-{ https://lizards.opensuse.org/2010/02/11/new-osc-feature-to-review-requests/#comment-1476 Thu, 11 Feb 2010 10:52:00 +0000 http://lizards.opensuse.org/?p=3210#comment-1476 Yes that might be possible too but “osc request review…” is already used to change the “review state” of a request.

]]>
By: Ludwig Nussel https://lizards.opensuse.org/2010/02/11/new-osc-feature-to-review-requests/#comment-1474 Thu, 11 Feb 2010 09:27:05 +0000 http://lizards.opensuse.org/?p=3210#comment-1474 what about introducing a new subcommand instead of adding options to ‘show’? e.g. osc request review $ID?

]]>